The patent image shows the upper and lower part as extremely thin (patent images are always messed up intentionally). While on the iPod and iPhones we have quite a bit of space beyond the screen on top and bottom. I think it`ll work nice enough especially in those games which opt for floating analog sticks instead of fixed ones.
Wow, I would have expected the votes to be weighed a lot to one side, but they're pretty even. The only way I would get one is if most games (that would benefit from it) were compatible with it, and if there was an option on those games to play without it (touch/accelerometer controls). I don't want a game that can ONLY be played with an external device; it should at least play well without it so that when I'm out and about (without the controller with me) I could still play the games.
I'd buy a controller if it could: -have its own battery power or even charge the iPhone while playing -could use it as a Bluetooth controller for this rumored tablet. Since it's supposed to have a 10 inch screen, I'd seriously doubt that you'll be able to play these fps's and racing games holding a screen that huge.
I think a gamepad attachment would only go to fuel the notion that the iPhone is trying to do things it's not supposed to. iPhones and iPod Touches should be for touch and accelerometer based games, adding a controller attachment simply makes the device look like a failed PSP clone and greatly emphasizes the fact that games such as FPS don't control well enough.